Some of the issues have been touched on, but there is sort of a mistake in the thinking regarding an investor that believes a share will go up. Total return includes dividends. Also, there are multiple motivations possible in loaning shares for short selling.
Let's start with retail investors first. No share in a cash account for a retail investor can be loaned for the purpose of shorting. Conversely, you cannot generally block you broker from loaning out your shares, without ever telling you they did so, in a margin account. In some cases, though, you can request particular shares to be placed in a segregated cash account.
The exchange the retail investor receives is access to credit at a relatively low cost. If the shares are loaned out, then the broker pays a markup on passed dividends. Instead, the shareholder receives interest that is taxed as interest and not dividends. The markup is designed to cover the tax effects.
For institutions, they receive a fee to allow securities either to be loaned or placed under repurchase agreements.
Now let us consider the case where the fee is zero, why would anyone still do that? Imagine that you own shares in XYZ that you purchased at $5 per share that currently sells for $25 per share. You believe the present value of future dividends for the firm is $35 per share, but your margin of error is plus or minus $10 so you do not make a purchase. If you loan the shares out and the price falls, then you can purchase more shares. Were it not for the inability to track who buys and sells from whom, you could even purchase your own loaned shares back from the borrower.
Short selling will reduce the price, but that may be something that you want. It can be the case that the markup is very large relative to your actual tax obligation. Since the broker cannot see the true tax rate for the customer base, it must markup the cost of the passed dividend to the highest rate. For a firm that does not pay dividends, a key defense is against short sellers is to start paying a dividend.
Imagine that you have long felt that the firm should be paying dividends, but the board is not issuing them. Allowing short selling can trigger the very dividend you want but at a very marked-up price. Also important, the dividend payment may cause the long-run price to be higher than the current price.